style(badge): added a min-inline-size
#4715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
especially for single character contents
7 tasks
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/372-text-badge-sollte-nicht-schmaler-als-rund-werden |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mfranzke
changed the title
min-inline-size
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a minimum inline size to the badge component to ensure badges don't become narrower than a circle, particularly for single-character content.
- Added CSS rules to set a minimum inline size for non-empty badges
- Applied content-box sizing to ensure proper dimension calculations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
michaelmkraus
previously approved these changes
Aug 13, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
michaelmkraus
approved these changes
Aug 13, 2025
mfranzke
deleted the
372-text-badge-sollte-nicht-schmaler-als-rund-werden
branch
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in UX Engineering Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added a
min-inline-sizeespecially for single character contents, to ensure that it won't get any narrower than a circle.Resolves db-ux-design-system/core#372
Types of changes
Further comments